-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#171 responsive web design #179
Conversation
Signed-off-by: Philipp Kramer <[email protected]>
…re-oscilloscope into feature/#122-rescale-window
Signed-off-by: Philipp Kramer <[email protected]>
…re-oscilloscope into feature/#122-rescale-window
Signed-off-by: Philipp Kramer <[email protected]>
Signed-off-by: Philipp Kramer <[email protected]>
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Any specific reason why you removed the "mui" prefix? I followed that pattern in other PRs.
Also I can would expect merge issues with Feature/#168 Rework UI for presets as the preset stuff changed a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…d distribute button Signed-off-by: Philipp Kramer <[email protected]>
Thanks, @nicolaskolbenschlag ! Edit: Translated comment from German to English |
Removed it cause we no longer use only mui (material ui) icons. Didn't want it to be confusing and inconsistent going forward. Hope I didn't break too much on your end ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mine looks fine: (Tested on Edge) |
Signed-off-by: Philipp Kramer <[email protected]>
…re-oscilloscope into feature/#171-responsive-web-design
…gn' into feature/#171-responsive-web-design
Signed-off-by: Philipp Kramer <[email protected]>
…ure/#171-responsive-web-design Signed-off-by: Philipp Kramer <[email protected]>
Signed-off-by: Philipp Kramer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works fine for me in opera in dark mode and light mode
Signed-off-by: Philipp Kramer <[email protected]>
Let me know if the layout works as expected on your devices and of course, if you have any suggestions for improvement (both code & look) :)