Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#171 responsive web design #179

Merged
merged 16 commits into from
Jan 23, 2023
Merged

Conversation

PhlppKrmr
Copy link
Collaborator

@PhlppKrmr PhlppKrmr commented Jan 18, 2023

Let me know if the layout works as expected on your devices and of course, if you have any suggestions for improvement (both code & look) :)

@PhlppKrmr PhlppKrmr linked an issue Jan 18, 2023 that may be closed by this pull request
14 tasks
@cypress
Copy link

cypress bot commented Jan 18, 2023



Test summary

33 0 0 0


Run details

Project sosci-frontend
Status Passed
Commit 91c4e51
Started Jan 23, 2023 5:35 PM
Ended Jan 23, 2023 5:37 PM
Duration 02:37 💡
OS Linux Ubuntu - 22.04
Browser Chrome 109

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@PhlppKrmr
Copy link
Collaborator Author

Please also lmk which button you'd prefer for the distribution (ignore the hover effect and size differences):
1)
image
2)
image

Copy link
Collaborator

@jandegen jandegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Any specific reason why you removed the "mui" prefix? I followed that pattern in other PRs.

Also I can would expect merge issues with Feature/#168 Rework UI for presets as the preset stuff changed a bit

@jandegen
Copy link
Collaborator

Please also lmk which button you'd prefer for the distribution (ignore the hover effect and size differences): 1) image 2) image

Thumps up reaction for icon 1!
Party reation for icon 2!

Copy link
Contributor

@nicolaskolbenschlag nicolaskolbenschlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sliders are not anymore visible.

image

@PhlppKrmr
Copy link
Collaborator Author

The sliders are not anymore visible.

image

What broswer are you using here?

@nicolaskolbenschlag
Copy link
Contributor

The sliders are not anymore visible.
image

What broswer are you using here?

Chrome

@PhlppKrmr
Copy link
Collaborator Author

PhlppKrmr commented Jan 21, 2023

The sliders are not anymore visible.
image

What broswer are you using here?

Chrome

Thanks, @nicolaskolbenschlag !
Really strange, I tested it in Edge, Brave, Chrome and Firefox and for me they are visible. Adapted styling once again, lmk if you now see them.

Edit: Translated comment from German to English

@PhlppKrmr
Copy link
Collaborator Author

Looks good. Any specific reason why you removed the "mui" prefix? I followed that pattern in other PRs.

Also I can would expect merge issues with Feature/#168 Rework UI for presets as the preset stuff changed a bit

Removed it cause we no longer use only mui (material ui) icons. Didn't want it to be confusing and inconsistent going forward. Hope I didn't break too much on your end ;)

Copy link
Contributor

@nicolaskolbenschlag nicolaskolbenschlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmh, really strange. I tested it with Chrome and Edge and it still looks like this. Do the others also have this problem?

image

@jandegen
Copy link
Collaborator

The sliders are not anymore visible.
image

What broswer are you using here?

Chrome

Thanks, @nicolaskolbenschlag ! Really strange, I tested it in Edge, Brave, Chrome and Firefox and for me they are visible. Adapted styling once again, lmk if you now see them.

Edit: Translated comment from German to English

Mine looks fine: (Tested on Edge)

image
image

@PhlppKrmr PhlppKrmr requested a review from jandegen January 22, 2023 18:52
Copy link
Collaborator

@rabbit-zero rabbit-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine for me in opera in dark mode and light mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Responsive web design
4 participants