Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal head #80

Closed
4 of 14 tasks
dev3225 opened this issue Nov 22, 2022 · 3 comments · Fixed by #112
Closed
4 of 14 tasks

Signal head #80

dev3225 opened this issue Nov 22, 2022 · 3 comments · Fixed by #112

Comments

@dev3225
Copy link
Collaborator

dev3225 commented Nov 22, 2022

User story

  1. As a user
  2. I need a shaded circle at the current plotting point
  3. So that I can find how the signal is propagating.

Acceptance criteria

  • The signal head should be larger than line thickness.
  • Clearly visible to the user.
  • Does not interfere with the signal values.
  • Signal head should be applicable to each channel.

Definition of done (DoD)

  • Application compiles successfully
  • Code is documented
  • Feature/Bug/Change is tested by at least one unit or e2e test
  • Tests have been passed without warnings (except "deprecated" warnings)
  • Changes have been reviewed
  • PR has been merged to dev branch
  • New dependencies have been added to bill of materials
  • Software architecture diagram has been updated
  • All acceptance criteria are fulfilled
  • Screenshot is attached to issue

DoD general criteria

  • Feature has been fully implemented
  • Feature has been merged into the mainline
  • All acceptance criteria were met
  • Product owner approved features
  • All tests are passing
  • Developers agreed to release
@dev3225
Copy link
Collaborator Author

dev3225 commented Nov 22, 2022

For reference:

image

@dev3225 dev3225 moved this to Product Backlog in amos2022ws03-feature-board Nov 22, 2022
@jenswaechtler
Copy link
Contributor

jenswaechtler commented Nov 22, 2022

Could you explain why the feature is needed and how it should behave when multiple signals are to be displayed?

@dev3225
Copy link
Collaborator Author

dev3225 commented Nov 23, 2022

In an analog oscilloscopes, the CRT projects the beam onto the screen and that is how we are able to view the signal. Here we are trying to replicate what it would look like in an analog oscilloscope.
So, what we could understand from the client is that the point at which the signal is updated should have a kind of marker(here kind of a comet head) which makes it possible for the user to distinguish between already plotted signal and the point at which new data is being plotted.

@dev3225 dev3225 removed this from the Sprint 06 (Mid-Release) milestone Nov 29, 2022
@sjelodari sjelodari added this to the Sprint 07 milestone Nov 30, 2022
@sjelodari sjelodari moved this from Product Backlog to Sprint Backlog in amos2022ws03-feature-board Nov 30, 2022
@nicolaskolbenschlag nicolaskolbenschlag self-assigned this Nov 30, 2022
@nicolaskolbenschlag nicolaskolbenschlag moved this from Sprint Backlog to In Progress in amos2022ws03-feature-board Nov 30, 2022
nicolaskolbenschlag added a commit that referenced this issue Dec 1, 2022
nicolaskolbenschlag added a commit that referenced this issue Dec 6, 2022
first working draft of implementation for #80 signal head
Repository owner moved this from In Progress to Awaiting Review in amos2022ws03-feature-board Dec 6, 2022
@dev3225 dev3225 moved this from Awaiting Review to Feature Archive in amos2022ws03-feature-board Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment