Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed of values being displayed may be not realistic? #160

Closed
nicolaskolbenschlag opened this issue Jan 11, 2023 · 3 comments
Closed

Speed of values being displayed may be not realistic? #160

nicolaskolbenschlag opened this issue Jan 11, 2023 · 3 comments
Assignees
Milestone

Comments

@nicolaskolbenschlag
Copy link
Contributor

Actual behavior
This came up when considering the unit of the time-sweep indicator (#151). But is has to do with time-sweep only indirectly. If this is an issue, it does not come from the time-sweep itseld but more from the overall way of how data is processed and displayed in the frontend.

Expected behavior
Other oscilloscopes might (as I understood) display new data in their own speed, meaning a new div (pixel, respectively) in a fixed amount of time (unit: [time/div]). Also, Wieland said that our time-sweep should be unit time/div. But currently that is not what our oscilloscopse (and by this also our time-sweep) does.

Additional context
Changing this would require changing the whole way of how data is processed in the frontend (I guess).

@nicolaskolbenschlag nicolaskolbenschlag added the bug Something isn't working label Jan 11, 2023
@nicolaskolbenschlag nicolaskolbenschlag changed the title Speed of value display maybe not correct?! Speed of values being displayed may be not correct?! Jan 11, 2023
@nicolaskolbenschlag nicolaskolbenschlag changed the title Speed of values being displayed may be not correct?! Speed of values being displayed may be not realistic? Jan 11, 2023
@dev3225 dev3225 moved this from Product Backlog to Sprint Backlog in amos2022ws03-feature-board Jan 11, 2023
@dev3225 dev3225 added this to the Sprint 11 milestone Jan 11, 2023
nicolaskolbenschlag added a commit that referenced this issue Jan 12, 2023
Signed-off-by: nicolaskolbenschlag <[email protected]>
@sjelodari sjelodari moved this from Sprint Backlog to Product Backlog in amos2022ws03-feature-board Jan 18, 2023
@sjelodari sjelodari moved this from Product Backlog to Sprint Backlog in amos2022ws03-feature-board Jan 18, 2023
@nicolaskolbenschlag
Copy link
Contributor Author

nicolaskolbenschlag commented Jan 19, 2023

Leon and me compared our ideas and agreed on how to proceed:

  • Where we stand:
  • The speed in which our oscilloscope plots in dependent on the frequency in which it receives packages
  • This receive-speed is dendent on the sending frequency of the backend (which is the generator's frequency divided by 200)
  • Hence, the display speed is determined by the backend. It is of unit "div per update" and not "time per div" (as it is supposed to be)
  • Workarounds:
  • Obtain the time per update and compute the time per div, as we know how many divs refer to one update (namely one pixel per update times time-sweep)
  • Our ideas differed in how we obtain the time per update:

Option 1: Use a constant as we know the frequency of our generator (drawback: more unrealistic as it only works for our generator and no other "sensor")
Option 2: Compute the time per update empirically on update (drawback: computation overhead and very laggy even if only measured at every 10_000 update or so)

  • Next steps:

nicolaskolbenschlag added a commit that referenced this issue Jan 19, 2023
…weep computation to seperate helper so that it can be reused by slider's display-value

Signed-off-by: nicolaskolbenschlag <[email protected]>
@leon-juenemann leon-juenemann moved this from Sprint Backlog to In Progress in amos2022ws03-feature-board Jan 25, 2023
@dev3225 dev3225 moved this from In Progress to Product Backlog in amos2022ws03-feature-board Jan 25, 2023
@dev3225 dev3225 modified the milestones: Sprint 11, Sprint 13 Jan 25, 2023
@dev3225 dev3225 moved this from Product Backlog to Sprint Backlog in amos2022ws03-feature-board Jan 25, 2023
nicolaskolbenschlag added a commit that referenced this issue Jan 25, 2023
Signed-off-by: nicolaskolbenschlag <[email protected]>
@nicolaskolbenschlag
Copy link
Contributor Author

nicolaskolbenschlag commented Jan 25, 2023

Current display speed computation:

  • Expect number of updates from generator/backend per second (as constant = 10_000)
  • From this, the overall width (1000 pixels) and the number of divs (=20), we can compute the expected time per div (without time sweep):
  • time_per_update = 1 / 1000 s
  • pixels_per_div = 1000 / 20 = 50
  • time_per_div = time_per_update * pixels_per_div = 50 / 1000 = 0,005s

@nicolaskolbenschlag nicolaskolbenschlag moved this from Sprint Backlog to In Progress in amos2022ws03-feature-board Jan 25, 2023
nicolaskolbenschlag added a commit that referenced this issue Jan 29, 2023
Signed-off-by: nicolaskolbenschlag <[email protected]>
nicolaskolbenschlag added a commit that referenced this issue Jan 29, 2023
Signed-off-by: nicolaskolbenschlag <[email protected]>
nicolaskolbenschlag added a commit that referenced this issue Jan 29, 2023
nicolaskolbenschlag added a commit that referenced this issue Jan 29, 2023
nicolaskolbenschlag added a commit that referenced this issue Jan 29, 2023
…ant-merge

Merge with this PR the same changes as #183 which was reviewed. I created this branch+PR because of merge conflicts
@nicolaskolbenschlag nicolaskolbenschlag moved this from In Progress to Awaiting Review in amos2022ws03-feature-board Jan 29, 2023
@jandegen
Copy link
Collaborator

jandegen commented Feb 1, 2023

The displayed sweep speed still not matches the actual sweep speed.
The indicators display 5ms/div (with 1 div is one grid block)

Image

The real sweep speed feals more like 1 sec for 2 div, but that's not an correct measure, more like gut feeling

@sjelodari sjelodari moved this from Awaiting Review to Feature Archive in amos2022ws03-feature-board Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Feature Archive
Development

No branches or pull requests

5 participants