Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix graph updates #401

Merged
merged 4 commits into from
Jul 13, 2021
Merged

Fix graph updates #401

merged 4 commits into from
Jul 13, 2021

Conversation

CatoLeanTruetschel
Copy link
Collaborator

@CatoLeanTruetschel CatoLeanTruetschel commented Jul 10, 2021 •
edited
Loading

Closes #384, closes #385

@CatoLeanTruetschel CatoLeanTruetschel self-assigned this Jul 10, 2021
joluj
joluj approved these changes Jul 10, 2021
View reviewed changes
Copy link
Collaborator

@joluj joluj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! finally :D
It still updates when you search for an entity. But it's way nicer than before.

@CatoLeanTruetschel
Copy link
Collaborator Author

@joluj It does? Then I have to take a closer look into this too.

@joluj
Copy link
Collaborator

joluj commented Jul 10, 2021

@joluj It does? Then I have to take a closer look into this too.

Yes, but it's ready to merge IMO. I'd suggest opening an issue and resolve it later.

@joluj joluj mentioned this pull request Jul 11, 2021
Merged
@joluj joluj closed this in 0703b1f Jul 11, 2021
@CatoLeanTruetschel
Copy link
Collaborator Author

@joluj Why did you close this?

@joluj
Copy link
Collaborator

joluj commented Jul 11, 2021

@joluj Why did you close this?

Typo 🤦🏽‍♂️ meant #402 instead... Sorry

@joluj joluj reopened this Jul 11, 2021
@CatoLeanTruetschel CatoLeanTruetschel merged commit 2fc5a34 into main Jul 13, 2021
@CatoLeanTruetschel CatoLeanTruetschel deleted the fix-graph-updates branch July 13, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joluj joluj joluj approved these changes

@PianoRollRepresentation PianoRollRepresentation Awaiting requested review from PianoRollRepresentation

@derwehr derwehr Awaiting requested review from derwehr

Assignees

@CatoLeanTruetschel CatoLeanTruetschel

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@CatoLeanTruetschel @joluj