Filter enhancement #357
Merged
Filter enhancement #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and rearrange initialization of FilterState to FilterStateStore.ts
joluj
requested changes
Jun 28, 2021
frontend/src/stores/SchemaStore.ts
Outdated
| @inject(LoadingStore) | ||
| private readonly loadingStore!: LoadingStore; | ||
|
|
||
| private initializedInternal = false; |
There was a problem hiding this comment.
Suggested change
| private initializedInternal = false; | |
| private initialized = false; |
frontend/src/stores/SchemaStore.ts
Outdated
Comment on lines
26
to
32
| /** | ||
| * Used to identify whether this store has already been filled with data from | ||
| * the {@link schemaService}. | ||
| */ | ||
| public get initialized(): boolean { | ||
| return this.initializedInternal; | ||
| } |
There was a problem hiding this comment.
Suggested change
| /** | |
| * Used to identify whether this store has already been filled with data from | |
| * the {@link schemaService}. | |
| */ | |
| public get initialized(): boolean { | |
| return this.initializedInternal; | |
| } |
frontend/src/stores/SchemaStore.ts
Outdated
| this.initializedInternal = true; | ||
| this.executeQuery().subscribe({ | ||
| next: (res) => { | ||
| if (res) { |
There was a problem hiding this comment.
res cannot be null right? If is not required
frontend/src/stores/SchemaStore.ts
Outdated
Comment on lines
38
to
42
| /** | ||
| * Updates the current state of this store with data fetched by | ||
| * the {@link schemaService}. | ||
| */ | ||
| public update(): void { |
There was a problem hiding this comment.
Suggested change
| /** | |
| * Updates the current state of this store with data fetched by | |
| * the {@link schemaService}. | |
| */ | |
| public update(): void { | |
| /** | |
| * @override | |
| */ | |
| protected ensureInit() { |
| }); | ||
| // only update the schemaStore on the very first time, the Filter is rendered. | ||
| // So no update happens when switching between tabs. | ||
| if (!schemaStore.initialized) { |
There was a problem hiding this comment.
Such information should not be published. Thus the SchemaStore should be changed a bit (use ensureInit functionality); See change requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #345.