-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hierarchical graph layout #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's currently just a single difference between Graph.tsx
and Hierarchies.tsx
. We should use the current file and just change a hierarchy flag to avoid duplicates.
We can discuss that in the dev meeting later since i have a proposal related to that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it that convertQueryResult was moved out of Graph.tsx.
However, Hierarchies is still just a copy of Graph.tsx. I think the best option would be to add a property "layout" to the Graph element and set that on "hierarchies" or "normal" or similar in routes.tsx
.
#137