Updated agent installer to actually work for 32bit #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to Issue #170, I've added some logic that'll change the systemd service that gets setup to call the 'amonagent32' binary rather than 'amonagent' for "i686" architectures. Not entirely pretty, but, it's better than failing as it does now.
"The binary for the agent is located in /usr/local/bin/amonagent", was not true for me when I installed. In my case it went to /usr/bin/amonagent.
Added installer check for debian that will lead to the unsupported message if on an architecture for which there isn't a suitable amonagent binary. I'm doing this because the installer ran fine on my armv7l machine, but the amonagent binary will not execute on it, nor would amonagent32 (obviously). Adjusted string comparison expressions to be more robust (if [ $DISTRO == "astring"] is not as good as if [ "$DISTRO" == "astring"] because when DISTRO is undefined, bash will crap its pants.
docdawning
commented
May 21, 2017
Decided the string comparisons ought to all use double-quotes.
OmgImAlexis
reviewed
Oct 23, 2017
| printf "\033[92m\n* Installing the Amon Agent package for Debian distros\n\033[0m\n" | ||
|
|
||
| $sudo_cmd apt-get install -y --force-yes amonagent | ||
|
|
||
| #Added in reply to https://github.com/amonapp/amon/issues/170 | ||
| ARCHITECTURE=`uname -m` |
There was a problem hiding this comment.
Why is there a check above for the ARCHITECTURE yet it isn't set until here?
This is causing installs to not work at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to Issue #170, I've added some logic that'll change the systemd service that gets setup to call the 'amonagent32' binary rather than 'amonagent' for "i686" architectures. Not entirely pretty, but, it's better than failing as it does now.