Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill the entire process group when a command times out #237

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sh.py
Original file line number Diff line number Diff line change
Expand Up @@ -1531,7 +1531,9 @@ def stderr(self):
def signal(self, sig):
self.log.debug("sending signal %d", sig)
try:
os.kill(self.pid, sig)
# Kill the entire process group as the command may have
# spawned subprocesses we don't want left around
os.killpg(os.getpgid(self.pid), sig)
except OSError:
pass

Expand Down