sh.py should not try to execute a folder #189
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: sh attempts to execute folders because which(1) fails
to determine that although folders may have execute-bit
set, they are not executable by execv(3)-family calls
Symptom: such call is blocking, never returns (!)
Solution: check the target is a file (following symlinks).
Details: The internal which(1) clone will attempt to execute any
folder matching the Command issued. So, given the PATH of:
[ As executing a folder would cause sh to block indefinitely
(an unhandled OSError is thrown on exec), the test adds a ._path
value assertion first, which prevents this test from hanging when
the fix is un-applied. ]