bugfix for poor sleep performance #378

amoffat · Jun 6, 2017 · 415cef7 · 415cef7
1 parent efdd6e4
commit 415cef7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 # Changelog
 
 ## 1.12.14 -
+*   bugfix for poor sleep performance [#378](https://github.com/amoffat/sh/issues/378)
 *   allow passing raw integer file descriptors for `_out` and `_err` handlers
 *   bugfix for when `_tee` and `_out` are used, and the `_out` is a tty or pipe [#384](https://github.com/amoffat/sh/issues/384)
 *   bugfix where python 3.3+ detected different arg counts for bound method output callbacks [#380](https://github.com/amoffat/sh/issues/380)

diff --git a/sh.py b/sh.py
@@ -2498,7 +2498,7 @@ def output_thread(log, stdout, stderr, timeout_event, is_alive, quit,
 
     # we need to wait until the process is guaranteed dead before closing our
     # outputs, otherwise SIGPIPE
-    alive = True
+    alive, _ = is_alive()
     while alive:
         quit.wait(1)
         alive, _ = is_alive()