Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/ambig parse token #24

Merged
merged 6 commits into from
Feb 3, 2024
Merged

Bug/ambig parse token #24

merged 6 commits into from
Feb 3, 2024

Conversation

amoffat
Copy link
Owner

@amoffat amoffat commented Feb 3, 2024

Description

In the sql select grammars, the boolean value was being treated as an elided tree, instead of a terminal value. Because it was an elided tree, it triggered the ambiguity resolver in some situations. The ambiguity resolver is designed to work on trees, not terminals, but lark was treating the elided tree as a terminal in this situation, causing it to fail.

Confirmations

These items must be confirmed for your pull request to be accepted. If you cannot accept these items, please explain why and we can try to work out a solution.

Code quality

Confirm that all of following are true:

  • My commits are descriptive and self-contained
  • I have written docstrings for any new code
  • All non-obvious additions and changes have been clearly commented
  • I have added test coverage for any code changes
  • I have added or updated the /docs where applicable

Compatibility

Confirm that at least one of the following is true:

  • These changes do not affect any behavior or interfaces (no version change)
  • These changes fix intended behavior or interfaces (patch/micro version change)
  • These changes add new behavior or interfaces (minor version change)
  • These changes alter existing behavior or interfaces (major version change)

Contribution rationale

Confirm that at least one of the following is true:

  • This contribution is a bug fix
  • This contribution is a documentation fix
  • This contribution is part of the public roadmap
  • This contribution was communicated in advance and approved by the author

Licensing

Confirm that one of the following is true:

  • I am contributing as individual and I have signed the Individual (CLA)
  • I am contributing on behalf of my employer and have signed the Corporate CLA

Copy link
Owner Author

@amoffat amoffat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@amoffat amoffat merged commit 735f11c into dev Feb 3, 2024
15 checks passed
@amoffat amoffat deleted the bug/ambig-parse-token branch February 3, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant