Make open_browser take AsRef<OsStr>, add open_path function #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since open_browser is the underlying implementation of
open
, I think making it provide anAsRef<OsStr>
interface is acceptable (per the previous PR). However,open
by default will only takeAsRef<str>
, while the new function,open_path
, will only acceptAsRef<Path>
.With regards to tests, is there anything in particular you would like to see? Would it be appropriate to add a simple test file and have all supported systems try to open this file?