[pull] main from microsoft:main

.github/workflows/roll_browser_into_playwright.yml

@@ -3,9 +3,21 @@ name: Roll Browser into Playwright
 on:
   repository_dispatch:
     types: [roll_into_pw]
+  workflow_dispatch:
+    inputs:
+      browser:
+        description: 'Browser name, e.g. chromium'
+        required: true
+        type: string
+      revision:
+        description: 'Browser revision without v prefix, e.g. 1234'
+        required: true
+        type: string
 
 env:
   ELECTRON_SKIP_BINARY_DOWNLOAD: 1
+  BROWSER: ${{ github.event.client_payload.browser || github.event.inputs.browser }}
+  REVISION: ${{ github.event.client_payload.revision || github.event.inputs.revision }}
 
 permissions:
   contents: write
@@ -24,19 +36,19 @@ jobs:
       run: npx playwright install-deps
     - name: Roll to new revision
       run: |
-        ./utils/roll_browser.js ${{ github.event.client_payload.browser }} ${{ github.event.client_payload.revision }}
+        ./utils/roll_browser.js $BROWSER $REVISION
         npm run build
     - name: Prepare branch
       id: prepare-branch
       run: |
-        BRANCH_NAME="roll-into-pw-${{ github.event.client_payload.browser }}/${{ github.event.client_payload.revision }}"
+        BRANCH_NAME="roll-into-pw-${BROWSER}/${REVISION}"
         echo "BRANCH_NAME=$BRANCH_NAME" >> $GITHUB_OUTPUT
         git config --global user.name github-actions
         git config --global user.email 41898282+github-actions[bot]@users.noreply.github.com
         git checkout -b "$BRANCH_NAME"
         git add .
-        git commit -m "feat(${{ github.event.client_payload.browser }}): roll to r${{ github.event.client_payload.revision }}"
-        git push origin $BRANCH_NAME
+        git commit -m "feat(${BROWSER}): roll to r${REVISION}"
+        git push origin $BRANCH_NAME --force
     - name: Create Pull Request
       uses: actions/github-script@v7
       with:
@@ -47,7 +59,7 @@ jobs:
             repo: 'playwright',
             head: 'microsoft:${{ steps.prepare-branch.outputs.BRANCH_NAME }}',
             base: 'main',
-            title: 'feat(${{ github.event.client_payload.browser }}): roll to r${{ github.event.client_payload.revision }}',
+            title: 'feat(${{ env.BROWSER }}): roll to r${{ env.REVISION }}',
           });
           await github.rest.issues.addLabels({
             owner: 'microsoft',

.github/workflows/tests_bidi.yml

@@ -7,7 +7,8 @@ on:
       - main
     paths:
       - .github/workflows/tests_bidi.yml
-      - packages/playwright-core/src/server/bidi/*
+      - packages/playwright-core/src/server/bidi/**
+      - tests/bidi/**
   schedule:
     # Run every day at midnight
     - cron: '0 0 * * *'

.github/workflows/tests_others.yml

@@ -147,6 +147,13 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
     - uses: actions/checkout@v4
+    - name: Setup Ubuntu Binary Installation # TODO: Remove when https://github.com/electron/electron/issues/42510 is fixed
+      if: ${{ runner.os == 'Linux' }}
+      run: |
+        if grep -q "Ubuntu 24" /etc/os-release; then
+          sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0
+        fi
+      shell: bash
     - uses: ./.github/actions/run-test
       with:
         browsers-to-install: chromium

.github/workflows/tests_primary.yml

@@ -215,6 +215,13 @@ jobs:
     - uses: actions/checkout@v4
     - run: npm install -g yarn@1
     - run: npm install -g pnpm@8
+    - name: Setup Ubuntu Binary Installation # TODO: Remove when https://github.com/electron/electron/issues/42510 is fixed
+      if: ${{ runner.os == 'Linux' }}
+      run: |
+        if grep -q "Ubuntu 24" /etc/os-release; then
+          sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0
+        fi
+      shell: bash
     - uses: ./.github/actions/run-test
       with:
         command: npm run itest

.github/workflows/tests_secondary.yml

@@ -107,6 +107,13 @@ jobs:
     - uses: actions/checkout@v4
     - run: npm install -g yarn@1
     - run: npm install -g pnpm@8
+    - name: Setup Ubuntu Binary Installation # TODO: Remove when https://github.com/electron/electron/issues/42510 is fixed
+      if: ${{ runner.os == 'Linux' }}
+      run: |
+        if grep -q "Ubuntu 24" /etc/os-release; then
+          sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0
+        fi
+      shell: bash
     - uses: ./.github/actions/run-test
       with:
         node-version: ${{ matrix.node_version }}

.gitignore

@@ -35,4 +35,4 @@ test-results
 .cache/
 .eslintcache
 playwright.env
-firefox
+/firefox/

FILING_ISSUES.md

@@ -0,0 +1,35 @@
+# How to File a Bug Report That Actually Gets Resolved
+
+Make sure you’re on the latest Playwright release before filing. Check existing GitHub issues to avoid duplicates.
+
+## Use the Template
+
+Follow the **Bug Report** template. It guides you step-by-step:
+
+- Fill it out thoroughly.
+- Clearly list the steps needed to reproduce the bug.
+- Provide what you expected to see versus what happened in reality.
+- Include system info from `npx envinfo --preset playwright`.
+
+## Keep Your Repro Minimal
+
+We can't parse your entire code base. Reduce it down to the absolute essentials:
+
+- Start a fresh project (`npm init playwright@latest new-project`).
+- Add only the code/DOM needed to show the problem.
+- Only use major frameworks if necessary (React, Angular, static HTTP server, etc.). 
+- Avoid adding extra libraries unless absolutely necessary. Note that we won't install any suspect dependencies.
+
+## Why This Matters
+- Most issues that lack a repro turn out to be misconfigurations or usage errors.
+- We can't fix problems if we can’t reproduce them ourselves.
+- We can’t debug entire private projects or handle sensitive credentials.
+- Each confirmed bug will have a test in our repo, so your repro must be as clean as possible.
+
+## More Help
+
+- [Stack Overflow’s Minimal Reproducible Example Guide](https://stackoverflow.com/help/minimal-reproducible-example)
+- [Playwright Debugging Tools](https://playwright.dev/docs/debug)
+
+## Bottom Line
+A well-isolated bug speeds up verification and resolution. Minimal, public repro or it’s unlikely we can assist.

README.md

@@ -1,16 +1,16 @@
 # 🎭 Playwright
 
-[![npm version](https://img.shields.io/npm/v/playwright.svg)](https://www.npmjs.com/package/playwright) <!-- GEN:chromium-version-badge -->[![Chromium version](https://img.shields.io/badge/chromium-132.0.6834.57-blue.svg?logo=google-chrome)](https://www.chromium.org/Home)<!-- GEN:stop --> <!-- GEN:firefox-version-badge -->[![Firefox version](https://img.shields.io/badge/firefox-132.0-blue.svg?logo=firefoxbrowser)](https://www.mozilla.org/en-US/firefox/new/)<!-- GEN:stop --> <!-- GEN:webkit-version-badge -->[![WebKit version](https://img.shields.io/badge/webkit-18.2-blue.svg?logo=safari)](https://webkit.org/)<!-- GEN:stop --> [![Join Discord](https://img.shields.io/badge/join-discord-infomational)](https://aka.ms/playwright/discord)
+[![npm version](https://img.shields.io/npm/v/playwright.svg)](https://www.npmjs.com/package/playwright) <!-- GEN:chromium-version-badge -->[![Chromium version](https://img.shields.io/badge/chromium-134.0.6998.15-blue.svg?logo=google-chrome)](https://www.chromium.org/Home)<!-- GEN:stop --> <!-- GEN:firefox-version-badge -->[![Firefox version](https://img.shields.io/badge/firefox-135.0-blue.svg?logo=firefoxbrowser)](https://www.mozilla.org/en-US/firefox/new/)<!-- GEN:stop --> <!-- GEN:webkit-version-badge -->[![WebKit version](https://img.shields.io/badge/webkit-18.2-blue.svg?logo=safari)](https://webkit.org/)<!-- GEN:stop --> [![Join Discord](https://img.shields.io/badge/join-discord-infomational)](https://aka.ms/playwright/discord)
 
 ## [Documentation](https://playwright.dev) | [API reference](https://playwright.dev/docs/api/class-playwright)
 
 Playwright is a framework for Web Testing and Automation. It allows testing [Chromium](https://www.chromium.org/Home), [Firefox](https://www.mozilla.org/en-US/firefox/new/) and [WebKit](https://webkit.org/) with a single API. Playwright is built to enable cross-browser web automation that is **ever-green**, **capable**, **reliable** and **fast**.
 
 |          | Linux | macOS | Windows |
 |   :---   | :---: | :---: | :---:   |
-| Chromium <!-- GEN:chromium-version -->132.0.6834.57<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
+| Chromium <!-- GEN:chromium-version -->134.0.6998.15<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
 | WebKit <!-- GEN:webkit-version -->18.2<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
-| Firefox <!-- GEN:firefox-version -->132.0<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
+| Firefox <!-- GEN:firefox-version -->135.0<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
 
 Headless execution is supported for all browsers on all platforms. Check out [system requirements](https://playwright.dev/docs/intro#system-requirements) for details.
 

browser_patches/firefox/UPSTREAM_CONFIG.sh

@@ -1,3 +1,3 @@
 REMOTE_URL="https://github.com/mozilla/gecko-dev"
 BASE_BRANCH="release"
-BASE_REVISION="bc78b98043438d8ee2727a483b6e10dedfda883f"
+BASE_REVISION="5cfa81898f6eef8fb1abe463e5253cea5bc17f3f"

browser_patches/firefox/juggler/TargetRegistry.js

@@ -393,7 +393,7 @@ class PageTarget {
     this._videoRecordingInfo = undefined;
     this._screencastRecordingInfo = undefined;
     this._dialogs = new Map();
-    this.forcedColors = 'no-override';
+    this.forcedColors = 'none';
     this.disableCache = false;
     this.mediumOverride = '';
     this.crossProcessCookie = {
@@ -635,7 +635,8 @@ class PageTarget {
   }
 
   updateForcedColorsOverride(browsingContext = undefined) {
-    (browsingContext || this._linkedBrowser.browsingContext).forcedColorsOverride = (this.forcedColors !== 'no-override' ? this.forcedColors : this._browserContext.forcedColors) || 'no-override';
+    const isActive = this.forcedColors === 'active' || this._browserContext.forcedColors === 'active';
+    (browsingContext || this._linkedBrowser.browsingContext).forcedColorsOverride = isActive ? 'active' : 'none';
   }
 
   async setInterceptFileChooserDialog(enabled) {
@@ -858,8 +859,8 @@ function fromProtocolReducedMotion(reducedMotion) {
 function fromProtocolForcedColors(forcedColors) {
   if (forcedColors === 'active' || forcedColors === 'none')
     return forcedColors;
-  if (forcedColors === null)
-    return undefined;
+  if (!forcedColors)
+    return 'none';
   throw new Error('Unknown forced colors: ' + forcedColors);
 }
 
@@ -893,7 +894,7 @@ class BrowserContext {
     this.forceOffline = false;
     this.disableCache = false;
     this.colorScheme = 'none';
-    this.forcedColors = 'no-override';
+    this.forcedColors = 'none';
     this.reducedMotion = 'none';
     this.videoRecordingOptions = undefined;
     this.crossProcessCookie = {

browser_patches/firefox/juggler/components/Juggler.js

@@ -105,7 +105,10 @@ class Juggler {
         };
 
         // Force create hidden window here, otherwise its creation later closes the web socket!
-        Services.appShell.hiddenDOMWindow;
+        // Since https://phabricator.services.mozilla.com/D219834, hiddenDOMWindow is only available on MacOS.
+        if (Services.appShell.hasHiddenWindow) {
+          Services.appShell.hiddenDOMWindow;
+        }
 
         let pipeStopped = false;
         let browserHandler;