[pull] main from microsoft:main #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* Renamed test job to `playwright-tests` to match docs and rererences * Added screenshot with github jobs and artifacts * Print Azure URL Fixes: #24451
Docs update to install Playwright as a dependency with Gradle, also introduce how to run Playwright CLI ```bash ./gradlew playwright --args="help" ``` Fixes [#571](microsoft/playwright-java#571)
Signed-off-by: ggorlen <[email protected]>
Co-authored-by: Max Schmitt <[email protected]>
…26511) Co-authored-by: Max Schmitt <[email protected]>
|
No applications have been configured for previews targeting branch: main. To do so go to restack console and configure your applications for previews. |
👋 Hi there!
|
|
Pull Request ReviewHey there! 👋 I've summarized the previous results for you. Here's a markdown document for your pull request review: Changes
Suggestions
Bugs
Improvements
async launchApp(options: {
sdkLanguage: string,
windowSize: types.Size,
windowPosition?: types.Point,
persistentContextOptions?: Parameters<BrowserType['launchPersistentContext']>[2];
}) {
const args = [...options.persistentContextOptions?.args ?? []];
if (this._name === 'chromium') {
args.push(
'--app=data:text/html,',
`--window-size=${options.windowSize.width},${options.windowSize.height}`,
...(options.windowPosition ? [`--window-position=${options.windowPosition.x},${options.windowPosition.y}`] : []),
'--test-type=',
);
}
// Rest of the method...
}RatingRate the code from 0 to 10 based on the following criteria: readability, performance, security. Explain briefly. Feel free to make any necessary changes or additions to this markdown document. Good luck with your pull request review! 🚀 |
Display `npx playwright`, `yarn playwright` or `pnpm exec playwright` in CLI Fixes #21425
There is no REST call for it, so we need to use GraphQL. References: - https://github.com/actions/github-script#run-custom-graphql-queries - https://docs.github.com/en/graphql/reference/mutations#minimizecomment - isaacs/github#1480
+ fix #24466 + Adds support for exposing the `pageerror` events via `browserContext` API. + Helps with capturing the overall exceptions that are thrown outside of the the current page and also captures the exceptions happens on other windows/popups. + Keeps the API in sync with `context.on('request)', context.on('console'), etc..`
This PR adds the `SoftAssertions` API for Java. Related PR: microsoft/playwright-java#1340 Note: microsoft/playwright.dev#1135 needs to be merged in order for the markdown in this PR to be rendered without errors
Failing tests for #26447.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )