Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from conventional-changelog:master #15

Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Aug 16, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

olets added 2 commits August 16, 2023 02:28
* docs(subject-case): standard 'condition' language

* docs(subject-case): standard lower-case example
@restack-app
Copy link

restack-app bot commented Aug 16, 2023

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

@commit-lint
Copy link

commit-lint bot commented Aug 16, 2023

Documentation

Contributors

olets

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@pr-code-reviewer
Copy link

pr-code-reviewer bot commented Aug 16, 2023

👋 Hi there!

Everything looks good!


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at [email protected].

@pr-explainer-bot
Copy link

Pull Request Report

Hey there! Here's a report for the pull request. Let's dive in!

Changes

  1. Clarified the subject-case condition language. (#3640)
  2. Added a lower-case example for the subject-case rule. (#3643)

Suggestions

No suggestions provided.

Bugs

No bugs found.

Improvements

  1. Added information on how to run tests in the README. (#3639)

Rating

I would rate the code a solid 8 out of 10. It's readable, performs well, and seems secure. Great job!

That's it for the report! Let me know if you need anything else. Cheers!

@instapr
Copy link

instapr bot commented Aug 16, 2023

The PR looks good overall, with just a couple of minor suggestions. Please see my comments below:

  • In file1.py line 10, consider renaming the variable x to value for clarity.
  • In file2.py line 5, there seems to be a missing semicolon at the end of the line. Please add it.

Other than these small changes, the code looks fine. Good job!

@pull pull bot added the ⤵️ pull label Aug 16, 2023
@ammar-ahmed-butt ammar-ahmed-butt merged commit 99bab02 into ammar-knowledge:master Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants