New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: stop having separate FileResourceLoader implementations per platform and rely on FileSystem instead. #396

Open

tomsfernandez wants to merge 1 commit into develop from file-rl-proposal

Contributor

tomsfernandez commented Dec 28, 2021 •

edited

Loading

Objective: have a way to unit-test the adapter logic inside the ResourceLoader implementations from a "shared" scala test suite.

This is also helpful to mock the "FileSystem" object and "spy" on the end products of AMF's uri-resolution mechanism. This is especially useful when debugging APIKIT Api Sync error cases.

Concerns

The only concern I have is regarding performance between the JvmFileSystem implementations and the legacy file reading mechanism. Unfortunately I don't see a way to easily benchmark this as disk I/O will affect the measurement a lot.

Note: this small refactor is made to be fully backwards compatible with the previous implementation.


          Proposal: stop having separate FileResourceLoader implementations per…

20e95f7

… platform and rely on FileSystem instead.

tomsfernandez requested review from looseale and nschejtman

June 8, 2022 15:02

nschejtman approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet