Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #1

Closed
wants to merge 1 commit into from
Closed

fix #1

wants to merge 1 commit into from

Conversation

lolmaus
Copy link

@lolmaus lolmaus commented Aug 13, 2018

No description provided.

@lolmaus lolmaus mentioned this pull request Aug 13, 2018
Open
amk221
amk221 requested changes Aug 13, 2018
View reviewed changes
Copy link
Owner

@amk221 amk221 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a suitable fix :)

The test should fail, yes, but not with _emberMetalProperty_get.get(...).getURL

@lolmaus
Copy link
Author

lolmaus commented Aug 13, 2018

This was an attempt to fix your test to unblock you on your business logic, not an attempt to resolve the framework's cryptic error issue.

@lolmaus lolmaus closed this Aug 13, 2018
@amk221
Copy link
Owner

amk221 commented Aug 13, 2018

Thanks, I realise that, and appreciate the input. But, I did create this repo with the null intentionally there in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amk221 amk221 amk221 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lolmaus @amk221