Skip to content

Commit

Permalink
remove sort query params
Browse files Browse the repository at this point in the history
- this override is incompatible with use of certain mocking libraries and blows away query params in those cases
- removing here since the underlying PR has been merged
  • Loading branch information
jaredgalanis committed Jan 20, 2022
1 parent f129d2b commit ed9e7a0
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions addon/mixins/url-templates.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,6 @@ export default Mixin.create({
return EmberObject.create(this.get('urlSegments'));
},

// HACK: Prevent query/queryRecord from appending query params to urls, we
// can do that in the template.
// TODO: ember-data plans to implement better hooks for customizing the
// request. Hopefully in the future, this hack can be removed and another
// hook used instead.
sortQueryParams(/* params */) {
return {};
},

_urlFromLink(snapshot, urlTemplate) {
if (LINK_PREFIX_RE.test(urlTemplate)) {
return this.buildURL(null, snapshot.id, snapshot, urlTemplate.replace(LINK_PREFIX_RE, ''), {});
Expand Down

0 comments on commit ed9e7a0

Please sign in to comment.