Added ts-loader example #167

johnnyreilly · 2017-06-01T21:11:15Z

This should resolve #164

I'm afraid I can't run the test as I'm on Windows. I've done my best to guess how it should work - may need your help there if it doesn't run. Fingers crossed!

codecov-io · 2017-06-01T21:13:50Z

Codecov Report

Merging #167 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   94.66%   94.66%           
=======================================
  Files          22       22           
  Lines         656      656           
=======================================
  Hits          621      621           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01b01d6...3bb9bba. Read the comment docs.

amireh · 2017-06-01T21:46:25Z

So responsive! Haha, thank you, I'll try it out as soon as I can.

amireh · 2017-06-01T22:06:33Z

Hmm, I'm seeing something strange where the fork-ts-checker plugin isn't despawning its services. Is this intended? The example fails to run because the process is never killed. Here's a snippet that shows the remaining (zombie) processes:

user:happypack$ ps -ef | grep ts-loader
user   18577     1 42 01:04 pts/19   00:00:00 ~/.nvm/versions/node/v6.3.1/bin/node --max-old-space-size=2048 ~/Workspace/Projects/happypack/examples/ts-loader--webpack2/node_modules/fork-ts-checker-webpack-plugin/lib/service.js
user   18583     1 44 01:04 pts/19   00:00:00 ~/.nvm/versions/node/v6.3.1/bin/node --max-old-space-size=2048 ~/Workspace/Projects/happypack/examples/ts-loader--webpack2/node_modules/fork-ts-checker-webpack-plugin/lib/service.js
user   18584     1 41 01:04 pts/19   00:00:00 ~/.nvm/versions/node/v6.3.1/bin/node --max-old-space-size=2048 ~/Workspace/Projects/happypack/examples/ts-loader--webpack2/node_modules/fork-ts-checker-webpack-plugin/lib/service.js
user   18586     1 41 01:04 pts/19   00:00:00 ~/.nvm/versions/node/v6.3.1/bin/node --max-old-space-size=2048 ~/Workspace/Projects/happypack/examples/ts-loader--webpack2/node_modules/fork-ts-checker-webpack-plugin/lib/service.js
user   18591     1 43 01:04 pts/19   00:00:00 ~/.nvm/versions/node/v6.3.1/bin/node --max-old-space-size=2048 ~/Workspace/Projects/happypack/examples/ts-loader--webpack2/node_modules/fork-ts-checker-webpack-plugin/lib/service.js
user   18602     1 43 01:04 pts/19   00:00:00 ~/.nvm/versions/node/v6.3.1/bin/node --max-old-space-size=2048 ~/Workspace/Projects/happypack/examples/ts-loader--webpack2/node_modules/fork-ts-checker-webpack-plugin/lib/service.js
user   18603     1 43 01:04 pts/19   00:00:00 ~/.nvm/versions/node/v6.3.1/bin/node --max-old-space-size=2048 ~/Workspace/Projects/happypack/examples/ts-loader--webpack2/node_modules/fork-ts-checker-webpack-plugin/lib/service.js
user   18614     1 39 01:04 pts/19   00:00:00 ~/.nvm/versions/node/v6.3.1/bin/node --max-old-space-size=2048 ~/Workspace/Projects/happypack/examples/ts-loader--webpack2/node_modules/fork-ts-checker-webpack-plugin/lib/service.js
user   18620     1 43 01:04 pts/19   00:00:00 ~/.nvm/versions/node/v6.3.1/bin/node --max-old-space-size=2048 ~/Workspace/Projects/happypack/examples/ts-loader--webpack2/node_modules/fork-ts-checker-webpack-plugin/lib/service.js
user   18626     1 78 01:04 pts/19   00:00:01 ~/.nvm/versions/node/v6.3.1/bin/node --max-old-space-size=2048 ~/Workspace/Projects/happypack/examples/ts-loader--webpack2/node_modules/fork-ts-checker-webpack-plugin/lib/service.js

I have to manually kill them to get this to clean up.

johnnyreilly · 2017-06-02T05:36:39Z

@pietr-oles can you comment on this please?

johnnyreilly · 2017-06-02T05:41:31Z

Let's try that again 😄 @piotr-oles would you be able to comment on this please? It sounds like there might be an issue with fork-ts-checker plugin despawning its services...

dziamid · 2017-06-02T15:22:02Z

This works great except with dll plugin. It builds the dll file, but the process does not exit.


Building the Webpack DLL...
Loaded environment variables for development:
{ BASE_API: '//api.dev2.noviopus.com/api', PORT: '3000' }
version 1.7.2
Happy[ts]: Version: 4.0.0-beta.1. Threads: 4
Happy[ts]: All set; signaling webpack to proceed.
Starting type checking service...
Using 2 workers with 2048MB memory limit
/home/dziamid/dev/noviopus/tsconfig.json


No type errors found
Version: typescript 2.3.3
Time: 28720ms
chunk    {0} reactBoilerplateDeps.dll.js (reactBoilerplateDeps) 12.8 MB [entry] [rendered] 
//hangs here

johnnyreilly · 2017-06-02T16:16:37Z

Thanks @dziamid - that's good to know. Hopefully @piotr-oles can advise. I may open an issue on fork checker to track.

piotr-oles · 2017-06-02T17:22:38Z

I'm working on it, will let you know :)

piotr-oles · 2017-06-02T21:35:04Z

The problem with fork-ts-checker-webpack-plugin was misleading configuration. I've released v0.2.0 with some improvements you can check in changelog.

The main change is removing blockEmit option and setting it automatically (false for 'watch' mode, true for 'one build' mode). Also, it doesn't start chokidar watcher on build mode (the process didn't want to exit because of files watcher).

amireh · 2017-06-02T22:10:38Z

I have verified that it works once we upgrade to 0.2.0 - merging this! Thanks all.

amireh · 2017-06-02T22:18:33Z

The README now indicates TypeScript compatibility - thank you all for your work.

johnnyreilly · 2017-06-03T06:27:36Z

I've simplified the example in the PR and removed api bits that are no longer part of fork-ts-checker. Hope that helps!

piotr-oles · 2017-06-02T21:35:45Z

examples/ts-loader--webpack2/package.json

+  "author": "John Reilly <[email protected]> ",
+  "license": "ISC",
+  "devDependencies": {
+    "fork-ts-checker-webpack-plugin": "^0.1.2",


Please, change it to ^2.0.0 :)

piotr-oles · 2017-06-02T21:36:28Z

examples/ts-loader--webpack2/webpack.config--raw.js

+    },
+    plugins: [
+        new ForkTsCheckerWebpackPlugin({
+            tslint: false, // disable tslint support


this is unnecessary now - it's disabled by default

piotr-oles · 2017-06-02T21:37:16Z

examples/ts-loader--webpack2/webpack.config--raw.js

+            tslint: false, // disable tslint support
+            watch: './src', // optional but improves performance (less stat calls)
+            workers: ForkTsCheckerWebpackPlugin.TWO_CPUS_FREE, // use multi-process mode, leave 2 cpu's free for builder and system
+            blockEmit: process.env.NODE_ENV === 'production' // for production make it synchronous


please, remove this - this is no longer useful - it's computed automatically

piotr-oles · 2017-06-02T21:38:23Z

examples/ts-loader--webpack2/webpack.config--raw.js

+    entry: './src/index.ts',
+    output: {
+        path: path.resolve(__dirname, 'dist'),
+        filename: '[name].raw.js'


I think it should be:

path: path.resolve(__dirname, 'dist--raw'), filename: '[name].js'

:)

oooh you might be right!

piotr-oles · 2017-06-02T21:39:17Z

examples/ts-loader--webpack2/webpack.config.js

+            watch: './src', // optional but improves performance (less stat calls)
+            workers: ForkTsCheckerWebpackPlugin.TWO_CPUS_FREE, // use multi-process mode, leave 2 cpu's free for builder and system
+            blockEmit: process.env.NODE_ENV === 'production' // for production make it synchronous
+        })


same as above - tslint and blockEmit is no longer needed :)

piotr-oles · 2017-06-03T16:58:37Z

I've forgot to submit revew yesterday, it was pending. Never mind, it's not up to date :)

Added ts-loader example

3bb9bba

johnnyreilly mentioned this pull request Jun 2, 2017

fork-ts-checker not despawning it's services TypeStrong/fork-ts-checker-webpack-plugin#11

Closed

amireh merged commit 9d258be into amireh:master Jun 2, 2017

johnnyreilly mentioned this pull request Jun 3, 2017

amend usage of fork-ts-checker-plugin as blockEmit removed #168

Merged

piotr-oles reviewed Jun 3, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added ts-loader example #167

Added ts-loader example #167

johnnyreilly commented Jun 1, 2017

codecov-io commented Jun 1, 2017 •

edited

Loading

amireh commented Jun 1, 2017

amireh commented Jun 1, 2017

johnnyreilly commented Jun 2, 2017

johnnyreilly commented Jun 2, 2017

dziamid commented Jun 2, 2017 •

edited

Loading

johnnyreilly commented Jun 2, 2017

piotr-oles commented Jun 2, 2017

piotr-oles commented Jun 2, 2017

amireh commented Jun 2, 2017

amireh commented Jun 2, 2017

johnnyreilly commented Jun 3, 2017

piotr-oles Jun 2, 2017

piotr-oles Jun 2, 2017

piotr-oles Jun 2, 2017

piotr-oles Jun 2, 2017

johnnyreilly Jun 3, 2017

piotr-oles Jun 2, 2017

piotr-oles commented Jun 3, 2017

Added ts-loader example #167

Added ts-loader example #167

Conversation

johnnyreilly commented Jun 1, 2017

codecov-io commented Jun 1, 2017 • edited Loading

Codecov Report

amireh commented Jun 1, 2017

amireh commented Jun 1, 2017

johnnyreilly commented Jun 2, 2017

johnnyreilly commented Jun 2, 2017

dziamid commented Jun 2, 2017 • edited Loading

johnnyreilly commented Jun 2, 2017

piotr-oles commented Jun 2, 2017

piotr-oles commented Jun 2, 2017

amireh commented Jun 2, 2017

amireh commented Jun 2, 2017

johnnyreilly commented Jun 3, 2017

piotr-oles Jun 2, 2017

Choose a reason for hiding this comment

piotr-oles Jun 2, 2017

Choose a reason for hiding this comment

piotr-oles Jun 2, 2017

Choose a reason for hiding this comment

piotr-oles Jun 2, 2017

Choose a reason for hiding this comment

johnnyreilly Jun 3, 2017

Choose a reason for hiding this comment

piotr-oles Jun 2, 2017

Choose a reason for hiding this comment

piotr-oles commented Jun 3, 2017

codecov-io commented Jun 1, 2017 •

edited

Loading

dziamid commented Jun 2, 2017 •

edited

Loading