Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the provider's configuration handling, error management, and code organization #602

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve the provider's configuration handling, error management, and code organization #602

wants to merge 1 commit into from

Conversation

felladrin
Copy link
Collaborator

@felladrin felladrin commented Dec 22, 2024 •
edited
Loading

Added

  • New ConfigError and ResourceError types for better error handling
  • Helper function getOptionalField for consistent configuration management
  • Input validation for API version
  • Improved SSL/TLS configuration with dedicated helper methods

Changed

  • Error messages with more context
  • Improved documentation for provider schema and functions
  • Better organization of provider resources by category
  • More consistent handling of optional configuration values
  • Fixed typo in IAMGroupMembershipConfig function name

Security

  • Improved SSL/TLS configuration handling
  • Added minimum TLS version requirement (TLS 1.2)
  • Better certificate validation

Technical Details

  • No breaking changes to the provider's public API
  • All changes maintain backward compatibility
  • Internal improvements focus on reliability and maintainability

Testing

  • Existing tests should pass without modification
  • Error handling improvements are covered by existing test cases

@felladrin felladrin force-pushed the refactor branch 5 times, most recently from a48e1a7 to 9a7706d Compare December 22, 2024 18:10
@felladrin
Improve code organization and error handling
da1a9c1 
- Add proper error types and handling with severity levels
- Improve SSL/TLS configuration and security
- Add helper functions for safer field access
- Enhance documentation and code organization
- Add proper constants and remove magic values
- Improve type definitions and validation
@felladrin felladrin changed the title Improve code organization and error handling Improve provider configuration and error handling Dec 22, 2024
@felladrin felladrin changed the title Improve provider configuration and error handling Improve the provider's configuration handling, error management, and code organization Dec 22, 2024
@felladrin felladrin marked this pull request as ready for review December 22, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@felladrin