Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pickling UUID objects #25

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Support pickling UUID objects #25

merged 4 commits into from
Oct 3, 2023

Conversation

lepenkinya
Copy link
Contributor

@lepenkinya lepenkinya commented Oct 2, 2023 •
edited
Loading

Pickle is not yet supported, here is a PR which make uuid object pickable.

@lepenkinya lepenkinya force-pushed the feature/support-pickle branch from 47eeb3d to 5ab3f16 Compare October 2, 2023 16:35
aminalaee
aminalaee reviewed Oct 2, 2023
View reviewed changes
Copy link
Owner

@aminalaee aminalaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. A small comment.

src/lib.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@lepenkinya lepenkinya force-pushed the feature/support-pickle branch from 5ab3f16 to f11dfba Compare October 2, 2023 18:20
@lepenkinya lepenkinya requested a review from aminalaee October 2, 2023 18:21
@lepenkinya lepenkinya force-pushed the feature/support-pickle branch from f11dfba to f06b3bf Compare October 2, 2023 18:59
@aminalaee aminalaee changed the title support pickle/unpickle Support pickling UUID objects Oct 3, 2023
aminalaee
aminalaee approved these changes Oct 3, 2023
View reviewed changes
Copy link
Owner

@aminalaee aminalaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍

@aminalaee aminalaee merged commit b278623 into aminalaee:main Oct 3, 2023
15 checks passed
@lepenkinya lepenkinya deleted the feature/support-pickle branch October 3, 2023 08:20
@aminalaee aminalaee mentioned this pull request Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminalaee aminalaee aminalaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lepenkinya @aminalaee