-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix installation in Windows #36
Conversation
It would be great if in the long term we fixed biomechanical-analysis-framework/CMakeLists.txt Lines 49 to 52 in 7c4a708
BUILD_SHARED_LIBS=ON ?
|
Yes, we opened #37. |
I rebased the branch and now the Windows CI is failing due to the |
That is because for static libraries private dependencies are promoted to public dependencies (as in general if B.a links A.a, to create an executable that links B.a you also need to link A.a, while if B.so links A.so you only need to link B.so). This is not a problem for header-only library, but CMake does not know this. See robotology/idyntree#1065 for a description of this. |
I would close this PR and not merge it since we found a solution to install the examples on Windows (see #37 (comment)). |
In the
CMakeLists.txt
I added an if statement to check if the operating system that is installing the project is Windows and if it is the flagBUILD_SHARED_LIBS
is set to OFF.CC @dariosortino