Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChangedStorage #170

Closed
torkleyy opened this issue Jun 8, 2017 · 1 comment
Closed

ChangedStorage #170

torkleyy opened this issue Jun 8, 2017 · 1 comment
Labels
feature-request hard wontfix

Comments

@torkleyy
Copy link
Member

torkleyy commented Jun 8, 2017

Related: #89

A ChangedStorage should provide a way of lazily computing other values, only if the given component was changed before. This is similar to FlaggedStorage (#93), however it checks modifications based on equality with the previous value.
@torkleyy
Copy link
Member Author

This has been decided to be too expensive in practice. One should instead use the FlaggedStorage. Also, an implementation of a ChangedStorage is only possible on the user side (or with knowledge of how far they read the modification events), thus, if there's a special case that needs equality checks, a user-provided implementation is better.

xMAC94x pushed a commit to xMAC94x/specs that referenced this issue Mar 10, 2021
@bors @torkleyy @azriel91
Merge amethyst#170
d226a24 
170: Create ci-script.sh r=azriel91 a=torkleyy



Co-authored-by: Thomas Schaller <[email protected]>
Co-authored-by: Azriel Hoh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request hard wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@torkleyy