synchronize CI functions with Amethyst #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomGillen
reviewed
Feb 9, 2021
Comment on lines
+1
to
+14
| { | ||
| "rust-analyzer.lens.enable": false, | ||
| "rust-analyzer.checkOnSave.overrideCommand": [ | ||
| "cargo", | ||
| "+nightly", | ||
| "clippy", | ||
| "-Z", | ||
| "unstable-options", | ||
| "--message-format=json", | ||
| "--workspace", | ||
| "--no-default-features", | ||
| "--all-targets" | ||
| ], | ||
| } |
There was a problem hiding this comment.
Why is this committed to the repo? The CodeLens disable in particular seems suspect?
|
@ezpuzz I have resolved the conflicts in this PR, but don't have permission to push the commit. Can you allow maintainers to edit the PR? |
TomGillen
added a commit
that referenced
this pull request
Feb 10, 2021
TomGillen
added
the
type: maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this copies the configuration from Amethyst repos github CI
this will keep org code consistent and test book in CI