-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minQuestionSize problem in padding #24
Comments
Would you like to submit a pull request? If you do, please also add a unit-test for this case. |
Sure. Will add unit tests too. |
zoli
added a commit
to zoli/dnscrypt
that referenced
this issue
Jan 11, 2024
fix problem with calculating closest divisible by 64 closes ameshkov#24
ameshkov
pushed a commit
that referenced
this issue
Mar 15, 2024
fix problem with calculating closest divisible by 64 closes #24
SamTherapy
pushed a commit
to SamTherapy/dnscrypt
that referenced
this issue
Apr 17, 2024
fix problem with calculating closest divisible by 64 closes ameshkov#24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From what I understand this line in
pad
function isn't right.It doesn't result in closes divisible by 64. For example if
packet
length is 56 it will result in 65 which should be 64 (the closest divisible by 64 to 56+1 is 64).I think it should get rewritten to STH like this:
The text was updated successfully, but these errors were encountered: