Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(semantic-release): disable body-max-line-length #50

Merged
merged 1 commit into from
Aug 10, 2023
Merged

fix(semantic-release): disable body-max-line-length #50

merged 1 commit into from
Aug 10, 2023

Conversation

JAdshead
Copy link
Contributor

@JAdshead JAdshead commented Aug 9, 2023 •
edited
Loading

Description

disable body-max-line-length to unblock release.

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using lumberjack?

@JAdshead JAdshead requested review from a team as code owners August 9, 2023 21:45
@PixnBits
Copy link
Contributor

PixnBits commented Aug 9, 2023

Motivation and Context

why?

@Matthew-Mallimo
Copy link
Member

to unblock release.

to unblock release.

@Matthew-Mallimo Matthew-Mallimo merged commit cfe76b5 into main Aug 10, 2023
@Matthew-Mallimo Matthew-Mallimo deleted the fix/semantic-release branch August 10, 2023 13:56
oneamexbot added a commit that referenced this pull request Aug 10, 2023
@oneamexbot
chore(release): 1.2.0 [skip ci]
5a50209 
# [1.2.0](v1.1.4...v1.2.0) (2023-08-10)

### Bug Fixes

* **commit-lint:** disable footer length limit ([#51](#51)) ([da17645](da17645))
* **semantic-release:** disable body-max-line-length ([#50](#50)) ([cfe76b5](cfe76b5))

### Features

* **node:** support 18 ([d4c4311](d4c4311))
@oneamexbot
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matthew-Mallimo Matthew-Mallimo Matthew-Mallimo approved these changes

@bishnubista bishnubista bishnubista approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JAdshead @PixnBits @Matthew-Mallimo @oneamexbot @bishnubista