Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pngjs version to 3.3.2 #54

Closed
wants to merge 1 commit into from
Closed

Upgrade pngjs version to 3.3.2 #54

wants to merge 1 commit into from

Conversation

euxn23
Copy link

@euxn23 euxn23 commented Mar 6, 2018

Upgrade pngjs to 3.3.2, to enable using with node v9.

pngjs/pngjs#95

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2018

CLA assistant check
All committers have signed the CLA.

@anescobar1991
Copy link
Member

This isn't needed as we use the caret(^) and so on any install it will pick up the latest minor or patch version for that package.

Will release in the next few days with this fix and a few other things :)

@anescobar1991
Copy link
Member

@euxn23 pngjs still is not fully node v9 compatible, I suggest you open up an issue with them. The following code which simulates where I see it failing in jest-image-snapshot reproduces the issue:

const { PNG } = require('pngjs');
const fs = require('fs')

const image = fs.readFileSync(process.cwd() + '/image-g.png');
PNG.sync.read(image);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants