chore: package-lock changes due to npm install (node v14.21.3) #350
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
npm install
made changes topackage-lock.json
.Motivation and Context
When following the CONTRIBUTING guide, I ran
npm install
using the latest LTS version of node (v20).npm
warned me about an old lockfile version and that it would rewrite it.However, the
lockfile-lint
dependency is not compatible with the latest lockfile version. I tried again with node v18 and v16 but it had the same issue. Finally, node v14 does not attempt to rewrite thepackage-lock.json
file and works withlockfile-lint
, however, it does still make a small change to the file.I don't see any documentation on what version of node should be used with the repository – is there a recommendation?
How Has This Been Tested?
npm run test
Types of Changes
Checklist:
What is the Impact to Developers Using Jest-Image-Snapshot?
Ensure to use the version of node specified in the documentation and
.nvmrc
file.