Adding arm64 architecture so it can be used on the M1 CircleCI hardware. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szweier
requested review from
grinish21,
stevologic,
utsavmaniyar and
nsc5171
as code owners
kalkwarf
approved these changes
Mar 15, 2023
| @@ -4,7 +4,7 @@ | |||
| ], | |||
| "plugins": [ | |||
| ["@semantic-release/github", { | |||
| "assets": ["go-earlybird-linux", "go-earlybird-macos", "go-earlybird.exe"], | |||
| "assets": ["go-earlybird-linux", "go-earlybird-macos", "go-earlybird.exe", "go-earlybird-arm64-macos"], | |||
There was a problem hiding this comment.
I'm not sure if we want to build fat, or just arm? My personal preference would be fat, but the trend on the internet appears to be platform specific, so as long as we can still build on Intel and Apple silicon at the same time, I guess this is fine.
There was a problem hiding this comment.
go build natively does not support fat binaries. We would need to use something which is not part of go-build -> golang/go#53281
grinish21
approved these changes
Mar 15, 2023
|
@grinish21 would you be able to merge this when you have a moment, it looks like I don't have write access to be able to merge the PR even with approvals. |
|
🎉 This PR is included in version 3.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.