feat(typescript): convert to typescript #51
+9,405
−8,147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Matthew-Mallimo
requested changes
Nov 8, 2024
zacowan
requested changes
Nov 8, 2024
xAndreiLi
force-pushed
the
feat/typescript
branch
4 times, most recently
from
00aec0e
to
6e48b3e
Compare
zacowan
reviewed
Nov 8, 2024
xAndreiLi
force-pushed
the
feat/typescript
branch
2 times, most recently
from
e661365
to
6b834c8
Compare
zacowan
reviewed
Nov 14, 2024
update tests to tsx match types version with dep versions generic type change to main/types to exports change build to dist change target to es6 update types/react to 18 to provide modern context type
xAndreiLi
force-pushed
the
feat/typescript
branch
from
6b834c8
to
f132a90
Compare
zacowan
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to convert this package to Typescript, allowing for both Javascript and Typescript projects to use it with added types for type-checking and IntelliSense.
Typescript was added as a dev dependency
File structure was changed to include src and build directories
tsc is used to transpile ts to js because of the package's simple output
Jest was updated in dev dependencies due to the previous version causing type errors
ESLint was updated
Tests now use tsx and test index.ts in src
build directory is gitignored and release runs build script
@types now matches installed dep versions (except for react)
types/react is installed @^18 due to React.Context type signature changing between 16 and 18
uses "exports" in package.json instead of main to supply built js and types
changed build dir to dist dir
changed target to es6 from 5 to remain at a version supporting all modern browsers
uses generic type for createReactSharedContext (WIP)