(ament_xmllint) add extensions argument (#456)

* (ament_xmllint) add extensions argument Signed-off-by: Matthijs van der Burgh <[email protected]> Co-authored-by: Chris Lalancette <[email protected]>
ament · Oct 24, 2023 · 7a5876e · 7a5876e
1 parent 10660ec
commit 7a5876e
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/ament_xmllint/ament_xmllint/main.py b/ament_xmllint/ament_xmllint/main.py
@@ -29,7 +29,7 @@
 
 
 def main(argv=sys.argv[1:]):
-    extensions = ['xml']
+    default_extensions = ['xml']
 
     parser = argparse.ArgumentParser(
         description='Check XML markup using xmllint.',
@@ -38,16 +38,22 @@ def main(argv=sys.argv[1:]):
         'paths',
         nargs='*',
         default=[os.curdir],
-        help='The files or directories to check. For directories files ending '
-             'in %s will be considered.' %
-             ', '.join(["'.%s'" % e for e in extensions]))
+        help='The files or directories to check. For directories, only files ending '
+             'in %s will be considered (unless overruled by the --extensions '
+             'option)' %
+             ', '.join(["'.%s'" % e for e in default_extensions]))
     parser.add_argument(
         '--exclude',
         nargs='*',
         default=[],
         help='Exclude specific file names and directory names from the check')
     # not using a file handle directly
     # in order to prevent leaving an empty file when something fails early
+    parser.add_argument(
+        '--extensions',
+        nargs='*',
+        default=default_extensions,
+        help='The file extensions of the files to check')
     parser.add_argument(
         '--xunit-file',
         help='Generate a xunit compliant XML file')
@@ -56,7 +62,7 @@ def main(argv=sys.argv[1:]):
     if args.xunit_file:
         start_time = time.time()
 
-    files = get_files(args.paths, extensions, args.exclude)
+    files = get_files(args.paths, args.extensions, args.exclude)
     if not files:
         print('No files found', file=sys.stderr)
         return 1