Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean when indicators showing #648

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Clean when indicators showing #648

merged 4 commits into from
Jan 24, 2025

Conversation

keyserj
Copy link
Collaborator

@keyserj keyserj commented Jan 24, 2025

Description of changes

  • see commit messages

Additional context

don't need an indicator to be able to select a node anymore, because
clicking node border allows this.

so the details indicator doesn't need to always show, and can just be
treated as a content indicator for notes.

not enough space in the content indictor section though, so just
shoehorned it into the status indicator section for now.

not ideal but it works. really wanted to do this so that UI can be less
cluttered when showing indicators.
Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for velvety-vacherin-4193fb ready!

Name Link
🔨 Latest commit f8723fd
🔍 Latest deploy log https://app.netlify.com/sites/velvety-vacherin-4193fb/deploys/6793fd48b33cb20007527093
😎 Deploy Preview https://deploy-preview-648--velvety-vacherin-4193fb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 80
Accessibility: 86
Best Practices: 92
SEO: 100
PWA: 80
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for ameliorate-docs canceled.

Name Link
🔨 Latest commit f8723fd
🔍 Latest deploy log https://app.netlify.com/sites/ameliorate-docs/deploys/6793fd48cc926b000868171b

because it adds a lot of clutter otherwise.

this includes moving the score to the side of the edge label so that
it's inline too.

also includes increasing how far edge label badges hang off because
otherwise they overlap with score slightly.
@keyserj keyserj force-pushed the clean-when-indicators-showing branch from 5d908c9 to de1bd22 Compare January 24, 2025 20:47
@keyserj keyserj merged commit 6bff922 into main Jan 24, 2025
10 checks passed
@keyserj keyserj deleted the clean-when-indicators-showing branch January 24, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant