Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

touchup: increase edge label width for layout #570

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

keyserj
Copy link
Collaborator

@keyserj keyserj commented Nov 25, 2024

Could use the average-width to try and balance using too much space vs using too little space, but it doesn't seem like a big deal to use too much space, whereas labels still overlapping basically forfeits a lot of the value of trying to avoid overlap.

Related #569

Description of changes

Additional context

Could use the average-width to try and balance using too much space vs
using too little space, but it doesn't seem like a big deal to use too
much space, whereas labels still overlapping basically
forfeits a lot of the value of trying to avoid overlap.
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for velvety-vacherin-4193fb ready!

Name Link
🔨 Latest commit df79de8
🔍 Latest deploy log https://app.netlify.com/sites/velvety-vacherin-4193fb/deploys/67448ca45ce61f000878c253
😎 Deploy Preview https://deploy-preview-570--velvety-vacherin-4193fb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 65
Accessibility: 86
Best Practices: 92
SEO: 100
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for ameliorate-docs canceled.

Name Link
🔨 Latest commit df79de8
🔍 Latest deploy log https://app.netlify.com/sites/ameliorate-docs/deploys/67448ca4341125000886f3a3

@keyserj
Copy link
Collaborator Author

keyserj commented Nov 25, 2024

Looks better imo and extra space doesn't seem bad - here are some before/after pics:

climate-change
image
image

cars-going-too-fast
image
image

@keyserj keyserj merged commit d853fe1 into main Nov 25, 2024
13 checks passed
@keyserj keyserj deleted the increase-edge-label-widths-for-layout branch November 25, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant