Fix store syncing unintentionally #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
could potentially use it for wiki-like topics
because notifications required a topic
previously would always sync when store changes, except when topic.id doesn't change. this was a problem because an SPA navigation that pulled in new changes would treat those as a diff and try to save them again. now, we add a flag to syncing middleware to control syncing - off when we're pulling data from local storage or the API, on otherwise. note: we also don't sync if we're on the playground. note2: this logic is being duplicated across stores. didn't want to take efforts to make code reusable, since this solution might not be used long-term (could switch to CRDT later).
had kind of hurt to look at. also darkened solution a little bit and reduced component saturation to further distinguish the two from each other.
✅ Deploy Preview for velvety-vacherin-4193fb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ameliorate-docs canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #556
Description of changes
Additional context