-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc touchups 9 #555
Merged
Merged
Misc touchups 9 #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it seems fine for a solution's direct effect to be in the same layer as a solution's component. this makes it easier to distinguish solution direct effects from component effects. also order components to the left of effects because they seem more important/core to solutions, so should come first when reading left-to-right.
they were pretty close and seemed easy to misclick between the two
specifically for topic description + node notes also remove unused text area text color also add vscode setting to add intellisense for className object props
previously was using some icons as the whole indicator, which was inconsistent in terms of the icons' borders.
seems like score of - or 5 should behave the same as unfilled indicator: i.e. blend in with background
trying to make the UI feel less-cluttered. indicators feel like they don't need to stand out as much as they currently do. includes using a lighter gray for filled indicators, for their borders, and removing shadow for button indicators.
so that it's consistent with other indicators. the score-pie is still a circle.
✅ Deploy Preview for velvety-vacherin-4193fb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ameliorate-docs canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Additional context