Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc touchups 9 #555

Merged
merged 7 commits into from
Nov 1, 2024
Merged

Misc touchups 9 #555

merged 7 commits into from
Nov 1, 2024

Conversation

keyserj
Copy link
Collaborator

@keyserj keyserj commented Nov 1, 2024

Description of changes

Additional context

it seems fine for a solution's direct effect to be in the same layer as
a solution's component.

this makes it easier to distinguish solution direct effects from
component effects.

also order components to the left of effects because they seem
more important/core to solutions, so should come first when
reading left-to-right.
they were pretty close and seemed easy to misclick between the two
specifically for topic description + node notes

also remove unused text area text color

also add vscode setting to add intellisense for className object props
previously was using some icons as the whole indicator,
which was inconsistent in terms of the icons' borders.
seems like score of - or 5 should behave the same as unfilled
indicator: i.e. blend in with background
trying to make the UI feel less-cluttered.
indicators feel like they don't need to stand out as much as they
currently do.

includes using a lighter gray for filled indicators,
for their borders, and
removing shadow for button indicators.
so that it's consistent with other indicators.
the score-pie is still a circle.
Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for velvety-vacherin-4193fb ready!

Name Link
🔨 Latest commit 844877e
🔍 Latest deploy log https://app.netlify.com/sites/velvety-vacherin-4193fb/deploys/672552bdd8a4110008a9d2f1
😎 Deploy Preview https://deploy-preview-555--velvety-vacherin-4193fb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 59
Accessibility: 86
Best Practices: 92
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for ameliorate-docs canceled.

Name Link
🔨 Latest commit 844877e
🔍 Latest deploy log https://app.netlify.com/sites/ameliorate-docs/deploys/672552bd706b9c00085b71be

@keyserj
Copy link
Collaborator Author

keyserj commented Nov 1, 2024

Mostly softening up some UI to reduce feel of clutter. I think the main part I'm uncertain about is the circle + shadow -> square + border for score. I guess we can always revert anyway.

Before:
image

After:
image

@keyserj keyserj merged commit d5f1470 into main Nov 1, 2024
13 checks passed
@keyserj keyserj deleted the misc-touchups-9 branch November 1, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant