Fix layout not good for different default font sizes #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for velvety-vacherin-4193fb canceled.
|
✅ Deploy Preview for ameliorate-docs canceled.
|
keyserj
force-pushed
the
fix-layout-not-good-for-different-default-font-sizes
branch
2 times, most recently
from
79ce491
to
e26ecff
Compare
includes grabbing the default font size from the root <html> element
keyserj
force-pushed
the
fix-layout-not-good-for-different-default-font-sizes
branch
from
e26ecff
to
047dacf
Compare
lots of grid -> flex with wrap, because large font-size makes it hard to predict grid-cols based on only screen size, where flex-wrap allows jumping to next row if there's any overflow.
also slightly increase gap to make it closer to the gap between justifcations in the justification details.
keyserj
force-pushed
the
fix-layout-not-good-for-different-default-font-sizes
branch
from
047dacf
to
737d85b
Compare
keyserj
deleted the
fix-layout-not-good-for-different-default-font-sizes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #535
Description of changes
Additional context