Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix start building return to #474

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Fix start building return to #474

merged 2 commits into from
Jul 26, 2024

Conversation

keyserj
Copy link
Collaborator

@keyserj keyserj commented Jul 26, 2024

Description of changes

Additional context

picture looks like "upload picture" which isn't accurate
Copy link

netlify bot commented Jul 26, 2024

Deploy Preview for ameliorate-docs canceled.

Name Link
🔨 Latest commit 356cad2
🔍 Latest deploy log https://app.netlify.com/sites/ameliorate-docs/deploys/66a423db78636400081854f7

Copy link

netlify bot commented Jul 26, 2024

Deploy Preview for velvety-vacherin-4193fb ready!

Name Link
🔨 Latest commit 356cad2
🔍 Latest deploy log https://app.netlify.com/sites/velvety-vacherin-4193fb/deploys/66a423db2e678a00081c5068
😎 Deploy Preview https://deploy-preview-474--velvety-vacherin-4193fb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 58
Accessibility: 86
Best Practices: 92
SEO: 85
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

when user click "start building", they'll initially be redirected to
/choose-username, but after that, they should be redirected back to
/new.

also removed `withPageAuthRequired` from /new because it shows
a blank page while it's loading. replaced with manual redirect if user
isn't logged in.
@keyserj keyserj force-pushed the fix-start-building-returnTo branch from 6dc312c to 356cad2 Compare July 26, 2024 22:31
@keyserj keyserj merged commit b21fbdc into main Jul 26, 2024
13 checks passed
@keyserj keyserj deleted the fix-start-building-returnTo branch July 26, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant