Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home page carousel accessibility #464

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Conversation

keyserj
Copy link
Collaborator

@keyserj keyserj commented Jul 19, 2024

Description of changes

Additional context

keyserj added 2 commits July 19, 2024 09:22
so that they can be clicked by vimium
so that react flow doesn't set role="button"; our custom
components handle all the interaction,
so this was just adding an extra tag for vimium, which was clutter-y
Copy link

netlify bot commented Jul 19, 2024

Deploy Preview for velvety-vacherin-4193fb ready!

Name Link
🔨 Latest commit a163a2d
🔍 Latest deploy log https://app.netlify.com/sites/velvety-vacherin-4193fb/deploys/669a7746fe44060008f5f132
😎 Deploy Preview https://deploy-preview-464--velvety-vacherin-4193fb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 46
Accessibility: 86
Best Practices: 92
SEO: 85
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 19, 2024

Deploy Preview for ameliorate-docs canceled.

Name Link
🔨 Latest commit a163a2d
🔍 Latest deploy log https://app.netlify.com/sites/ameliorate-docs/deploys/669a77466c7a410008e2c0b7

@keyserj keyserj merged commit 47befeb into main Jul 19, 2024
13 checks passed
@keyserj keyserj deleted the home-page-carousel-accessibility branch July 19, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant