Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic keyboard functionality #460

Merged
merged 6 commits into from
Jul 8, 2024
Merged

Basic keyboard functionality #460

merged 6 commits into from
Jul 8, 2024

Conversation

keyserj
Copy link
Collaborator

@keyserj keyserj commented Jul 8, 2024

Related #5

Description of changes

Additional context

  • should be able to use most of the tool, between these shortcuts and vimium's [fF]-to-click functionality

previously only implemented this for node select
also added partId to the selected event for possible future use
(e.g. focus the node that was selected too)
mui tooltip shows on click, which doesn't really help here.
tooltip can be nice on-touch for mobile, but that's not
relevant for buttons, since touch = click.
react flow puts its own .selected class on the outermost div,
but we should rely on our own .selected class, because
we fully control it.
Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for velvety-vacherin-4193fb ready!

Name Link
🔨 Latest commit 7414300
🔍 Latest deploy log https://app.netlify.com/sites/velvety-vacherin-4193fb/deploys/668c256a325721000852d308
😎 Deploy Preview https://deploy-preview-460--velvety-vacherin-4193fb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 53
Accessibility: 86
Best Practices: 92
SEO: 85
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for ameliorate-docs canceled.

Name Link
🔨 Latest commit 7414300
🔍 Latest deploy log https://app.netlify.com/sites/ameliorate-docs/deploys/668c256ac531fd0008ea021a

@keyserj keyserj merged commit 49048b6 into main Jul 8, 2024
13 checks passed
@keyserj keyserj deleted the basic-keyboard-functionality branch July 8, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant