Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow changing node/edge type #323

Merged
merged 2 commits into from
Jan 31, 2024
Merged

feat: allow changing node/edge type #323

merged 2 commits into from
Jan 31, 2024

Conversation

keyserj
Copy link
Collaborator

@keyserj keyserj commented Jan 31, 2024

  • some duplication but can refactor if more duplication is coming
  • context-menu is somewhat hidden so didn't require unrestricted editing

Description of changes

Additional context

  • feedback from discourse session

- some duplication but can refactor if more duplication is coming
- context-menu is somewhat hidden so didn't require unrestricted editing
Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for velvety-vacherin-4193fb ready!

Name Link
🔨 Latest commit 1c006ea
🔍 Latest deploy log https://app.netlify.com/sites/velvety-vacherin-4193fb/deploys/65bab4d55ff5bd0008615c22
😎 Deploy Preview https://deploy-preview-323--velvety-vacherin-4193fb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 66
Accessibility: 86
Best Practices: 92
SEO: 85
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

this was preventing "change edge type" from working with an edge
that has a custom label because the type would change but the custom
label would remain.
needed to ensure custom label could be null instead of undefined,
since prisma understands `undefined` as not to be updated for updates.

also made so that custom label does not get set if it's the same as the
edge type.
@keyserj keyserj merged commit d6b2d95 into main Jan 31, 2024
9 checks passed
@keyserj keyserj deleted the change-node-types branch January 31, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant