Skip to content

Commit

Permalink
touchup: use white for color of unscored
Browse files Browse the repository at this point in the history
seems like score of - or 5 should behave the same as unfilled
indicator: i.e. blend in with background
  • Loading branch information
keyserj committed Nov 1, 2024
1 parent 542f4e4 commit 7b58d4e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion src/web/topic/components/Score/PieChart.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,10 @@ export const PieChart = ({ onClick, customData, startAngle, type = "regular" }:

onClick(segmentData);
}}
background="white"
// use a gray background so that white segments have a clear edge (against diagram's white background, it's otherwise hard to tell where the pie ends)
background="#E1E1E1" // neutral-main
// stroke-46 with the background looks like a 1px border for radius 45 i.e. regular pie (don't care for button pie because it's got a border from its parent container)
className="[&_>_path:first-child]:stroke-[46]"
/>
</div>
</Tooltip>
Expand Down
2 changes: 1 addition & 1 deletion src/web/topic/utils/score.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import round from "lodash/round";
import { Score } from "@/web/topic/utils/graph";

export const scoreColors: Record<Score, keyof Palette> = {
"-": "neutral",
"-": "paper",
"1": "critique1",
"2": "critique2",
"3": "critique3",
Expand Down

0 comments on commit 7b58d4e

Please sign in to comment.