fix: tradeoffs filter lays out based on dupe nodes

throws layout off
amelioro · Feb 14, 2024 · 3f4a4b6 · 3f4a4b6
1 parent 26d2a57
commit 3f4a4b6
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/web/view/utils/filter.ts b/src/web/view/utils/filter.ts
@@ -1,3 +1,4 @@
+import uniqBy from "lodash/uniqBy";
 import { z } from "zod";
 
 import { RelationName, exploreRelationNames } from "../../../common/edge";
@@ -134,7 +135,11 @@ const applyTradeoffsFilter = (graph: Graph, filterOptions: TradeoffsOptions) =>
   const solutionDetails =
     filterOptions.detail === "none"
       ? []
-      : selectedSolutions.flatMap((solution) => ancestors(solution, graph, ["has", "creates"]));
+      : uniqBy(
+          // two solutions can share ancesotrs
+          selectedSolutions.flatMap((solution) => ancestors(solution, graph, ["has", "creates"])),
+          (node) => node.id
+        );
 
   const criteriaIds = selectedCriteria.map((criterion) => criterion.id);
   const filteredSolutionDetails =