This repository has been archived by the owner on Jul 8, 2021. It is now read-only.
Preventing modifications of the existing state #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many people use ngrx-store-freeze, which deep-freezes the state so that one didn't modify an existing state during development. If that's used, applying changes to the state object passed to the
@Action
-decorated function (e.g.state.loading = true
) will result inTypeError: Cannot assign to read only property 'loading' of object '[object Object]'
. I tested that with these changes the error doesn't occur, as the modification would then be applied to the new state instance.