Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure compatibility with crystal 0.27.0 #972

Closed
wants to merge 1 commit into from
Closed

Ensure compatibility with crystal 0.27.0 #972

wants to merge 1 commit into from

Conversation

waghanza
Copy link

@waghanza waghanza commented Nov 3, 2018

Hi,

According to https://github.com/crystal-lang/crystal/blob/master/CHANGELOG.md, there is some breaking change in crystal.

This PR is a starting point for compatibility.

Tempfile does not exists anymore, file.tempfile is used instead
crystal-lang/crystal#6485

Regards,

@waghanza
Copy link
Author

waghanza commented Nov 3, 2018

@faustinoaq for me the next error is due to crystal-lang/crystal#6514, but I don't if this is from teeplate or from amber

@drujensen
Copy link
Member

drujensen commented Nov 3, 2018

@waghanza thanks for this. I opened a new PR that includes all the needed changes #973. We are waiting for a Crecto update for the final specs to pass.

@drujensen drujensen closed this Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants