-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to crystal 0.26 #922
Conversation
@filename : String | ||
@filelogs : String | ||
|
||
def initialize(__previous, __argv) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use *args
and super
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was the minimum change. But it should be equivalent.
Also, there's one more:
|
I didn't detect that because building the specs does not stress that path 🤔 . To fix that, either something like kemalcr/kemal#477 can be done, or |
I also noticed that the shell-table shard version will need to be updated to support 0.26.0 jwaldrip/shell-table.cr#2 |
Note: This changes should be backward compatible with 0.25.1
Ref: crystal-lang/crystal#6414
ivar initializers will be evaluated without
self
in context.Disclaimer: I've only checked that the source build with crystal nightly together with this patch.