Adds data model conformance tests for nulls and booleans #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zslayton
approved these changes
Nov 15, 2024
Comment on lines
+31
to
+39
| (ion_1_x "in text, typed null suffix parsing has precedence over sexp operator rules" | ||
| (each (text "(null.)") | ||
| (text "(null.-)") | ||
| (text "(null..)") | ||
| (text "(null.true)") | ||
| (text "(null.1)") | ||
| (text "(null.nan)") | ||
| (text "(null.+inf)") | ||
| (text "(null.foo)") | ||
| (text "(null.[])") | ||
| (text "(null.())") | ||
| (text "(null.{})") | ||
| (signals "invalid type"))) |
There was a problem hiding this comment.
Nice! When we get to the tests for s-expressions, this will be one of a zillion corner cases to cover. 😵💫
| (then (binary 0xEB 0x0A) (denotes (Null sexp ))) | ||
| (then (binary 0xEB 0x0B) (denotes (Null struct )))) | ||
|
|
||
| (ion_1_x "Null denotations" |
There was a problem hiding this comment.
Do I understand correctly that this is checking whether the denotes operator is working as intended?
There was a problem hiding this comment.
I don't know. This was already part of the nulls file, so I kept it.
popematt
force-pushed
the
more-data-model
branch
from
b008c83 to
0a5f4c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#88
Description of changes:
Adds test cases for nulls and booleans as well as a few annotation test cases asserting that
true, etc. cannot be used as annotations.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.