-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jsonconversion #402
base: master
Are you sure you want to change the base?
Conversation
Updating jsonconversion past the broken version and the restrictive versions holding back pytest.
v1.1.0 removes `pytest-runner` and `pytest` from dependencies
Thanks for submitting this. Sadly it looks like If you want to go ahead and make the version conditional on the python version that would be great, otherwise this can pend until after the next release. |
@rmarrowstone I've added the version conditional. PTAL. thank you |
looking at the failures, it seems like pytest 6.2.5 uses a toml version that has trouble reading |
That is frustrating. The |
Is there a reason not to keep it on |
I'm fine with waiting until 6 months after Python 3.8 EOL before pushing this through (without the Python 3.8 compatibility). That puts us at Apr 7. (2024-10-07 + 6 months = April 7, 2025)
Trying to resolve an issue with updating dependencies. |
Updating jsonconversion past the broken version and the restrictive versions holding back pytest.
jsonconversion 1.1.0 removes
pytest-runner
andpytest
from dependencies[1].[1] DLR-RM/python-jsonconversion@1.0.3...1.1.0
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.