Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsonconversion #402

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

zachborboacryptofi
Copy link
Contributor

@zachborboacryptofi zachborboacryptofi commented Jan 23, 2025

Updating jsonconversion past the broken version and the restrictive versions holding back pytest.

jsonconversion 1.1.0 removes pytest-runner and pytest from dependencies[1].

[1] DLR-RM/python-jsonconversion@1.0.3...1.1.0

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Updating jsonconversion past the broken version and the restrictive versions holding back pytest.
v1.1.0 removes `pytest-runner` and `pytest` from dependencies
@rmarrowstone rmarrowstone self-requested a review January 23, 2025 15:24
@rmarrowstone
Copy link
Contributor

Thanks for submitting this. Sadly it looks like jsonconversion 1.1.0 is not available for python 3.8. We have an informal policy of supporting python versions up to 6 months past EOL. At current there are a bunch of unreleased changes and fixes that we intend to release shortly, so I'd like to cut one more release before pulling the plug on 3.8.

If you want to go ahead and make the version conditional on the python version that would be great, otherwise this can pend until after the next release.

@zachborboacryptofi
Copy link
Contributor Author

@rmarrowstone I've added the version conditional. PTAL. thank you

@zachborboacryptofi
Copy link
Contributor Author

looking at the failures, it seems like pytest 6.2.5 uses a toml version that has trouble reading pyproject.toml

@rmarrowstone
Copy link
Contributor

looking at the failures, it seems like pytest 6.2.5 uses a toml version that has trouble reading pyproject.toml

That is frustrating. The pyproject.toml is new and TBH I haven't even pulled those changes yet, so I can't really help more right now.

@rmarrowstone
Copy link
Contributor

Is there a reason not to keep it on jsonconversion==0.2.13 for 3.8?

@zachborboacryptofi
Copy link
Contributor Author

I'm fine with waiting until 6 months after Python 3.8 EOL before pushing this through (without the Python 3.8 compatibility). That puts us at Apr 7. (2024-10-07 + 6 months = April 7, 2025)

Is there a reason not to keep it on jsonconversion==0.2.13 for 3.8?

Trying to resolve an issue with updating dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants