Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drops support for Node 10.x, 12.x and adds 18.x #723

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Drops support for Node 10.x, 12.x and adds 18.x #723

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e97ef4
Drops support for Node 10.x, 12.x and adds 18.x
popematt Sep 8, 2022
6e9d1ab
Adds suggested change
popematt Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,25 +2,26 @@ name: Node.js CI

on:
push:
branches: [ master ]
branches: [ master, v5.0.0-development ]
pull_request:
branches: [ master ]
branches: [ master, v5.0.0-development ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
node-version: [10.x, 12.x, 14.x, 16.x]
node-version: [14.x, 16.x, 18.x]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick question here. According to the README.md, should this node-version also include 20?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake. README is wrong—Node 20 hasn't been released yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake. README is wrong—Node 20 hasn't been released yet.

Other than that, looks good to me.


steps:
- uses: actions/checkout@v2
with:
submodules: recursive
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- run: npm install
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ An implementation of [Amazon Ion](https://amzn.github.io/ion-docs/) for JavaScri
[![License](https://img.shields.io/hexpm/l/plug.svg)](https://github.com/amzn/ion-js/blob/master/LICENSE)
[![Documentation](https://img.shields.io/badge/docs-api-green.svg)](https://amzn.github.io/ion-js/api/index.html)

This package is tested with Node JS major versions **10**, **12**, **14**, and **16**. While this library
This package is tested with Node JS major versions **14**, **16**, **18**, and **20**. While this library
should be usable within browsers that support **ES5+**, please note that it is not currently being tested
in any browser environments.

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ion-js",
"version": "4.3.1-SNAPSHOT",
"version": "5.0.0-SNAPSHOT",
"description": "A JavaScript implementation of the Ion data interchange format",
"main": "dist/commonjs/es6/Ion.js",
"types": "dist/commonjs/es6/Ion.d.ts",
Expand Down