Refactors the release workflow #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheqianh
approved these changes
May 12, 2022
| with: | ||
| name: docs | ||
| path: docs/ | ||
| publish-to-github: |
There was a problem hiding this comment.
Ah nice we don't have to manually upload artifacts to GitHub release, I should apply it to ion-hive-serde release in the future.
There was a problem hiding this comment.
You authenticate by putting GITHUB_TOKEN in the env of the run step where you are using the gh CLI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Refactors the release workflow to have separate jobs that can be independently retried. Also, the workflow now opens a pull request instead of pushing directly to the
gh-pagesbranch.You can view a test of this workflow that I ran on a separate branch in my fork.
v125.1.0ofpopematt/ion-js.I am creating this PR from a different branch than I ran the test to ensure that the v125.1.0 tag does not get merged into
amzn/ion-jssomehow by mistake.The
.npmignorechange looks like a lot, but it is just adding.github,.nyc_output/,.prettierignore,test,test-driver, andtslint.json, and then I alphabetized the list.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.