Support new sematic conventions. #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjrara
reviewed
Dec 18, 2024
bjrara
approved these changes
Dec 18, 2024
bjrara
reviewed
Dec 18, 2024
lisguo
previously approved these changes
Dec 20, 2024
|
prometheus-compliance-tests failing..can you run |
lisguo
approved these changes
Jan 6, 2025
mxiamxia
approved these changes
Jan 7, 2025
lisguo
merged commit d03e737
into
amazon-contributing:aws-cwa-dev
123 of 146 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Similar as previous PR, this PR further update
awsxrayexporterto be able to handle following both new versions of httpspan attributes:
http.response.status_codemigrated from http.status_codeurl.querymigrated from http.target.Otel Java SDK has renamed
telemetry.auto.versiontotelemetry.distro.version(Upstream PR), updateawsxrayexporterto be able to detect both attributes.The PR also merged in latest semconv pkg and update existing semantic conventions utilization
Link to tracking Issue:
None
Testing:
Unit Test passed
Documentation:
Stable http span attributes: https://opentelemetry.io/blog/2023/http-conventions-declared-stable/
Telemetry Distro semantic convention: https://opentelemetry.io/docs/specs/semconv/resource/#telemetry-distro